Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't prompt user to install template package from CRAN #2495

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Apr 24, 2024

Fixes #2076

@hadley hadley requested a review from DavisVaughan April 24, 2024 13:54
@@ -331,12 +331,19 @@ package_vignettes <- function(path = ".") {
out[order(basename(out$file_out)), ]
}

find_template_config <- function(package, bs_version = NULL) {
find_template_config <- function(package,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is called from as_pkgdown(), so will be triggered early in all the build_* functions, and the call will point to a user facing function

R/utils-fs.R Outdated Show resolved Hide resolved
@hadley hadley merged commit 4a21528 into main Apr 24, 2024
12 checks passed
@hadley hadley deleted the template-package-missing branch April 24, 2024 19:42
SebKrantz pushed a commit to SebKrantz/pkgdown that referenced this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompted to install tidytemplate, but can't do it because it is GitHub only
2 participants